Upgrade Quantcast adapter for Prebid 1.0 #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 459ca31.
jaiminpanchal27
requested changes
Oct 24, 2017
modules/quantcastBidAdapter.js
Outdated
| method: 'POST', | ||
| url, | ||
| withCredentials: true |
There was a problem hiding this comment.
You don't need to pass withCredentials:true. Its already set in bidderFactory https://github.com/prebid/Prebid.js/blob/master/src/adapters/bidderFactory.js#L263
modules/quantcastBidAdapter.js
Outdated
| const { ad, cpm, width, height } = bid; | ||
|
|
||
| return { | ||
| ad, |
There was a problem hiding this comment.
Need to add required params. Please check http://prebid.org/dev-docs/bidder-adapter-1.html for list
Also bidderCode was previously required param but now you can remove that as it is handled by bidderFactory
modules/quantcastBidAdapter.js
Outdated
|
|
||
| adaptermanager.registerBidAdapter(new QuantcastAdapter(), 'quantcast'); | ||
| getUserSyncs(syncOptions) { |
There was a problem hiding this comment.
You can remove this method if not needed at this moment.
| * @return {Bid[]} An array of bids which were nested inside the server. | ||
| * | ||
| */ | ||
| interpretResponse(serverResponse) { |
There was a problem hiding this comment.
#1742 got merged recently.
The first argument to interpretResponse now looks like this:
{
body: responseBody,
headers: {
get: function(header) { /* returns a header from the HTTP response */ }
}
}
You'll have to pull master and update the spec so that it looks digs into that object as well now.
modules/quantcastBidAdapter.js
Outdated
| export const spec = { | ||
| code: BIDDER_CODE, | ||
|
|
||
| // `BaseAdapter` model saves adapter from having to make the AJAX call |
There was a problem hiding this comment.
This comment chunk can be removed.
|
I talked to our team and we are going add the missing required parameters later today. |
|
I have updated all the required changes @jaiminpanchal27 mentioned in the issue. The corresponding back-end change will deploy soon. |
jaiminpanchal27
approved these changes
Oct 25, 2017
matthewlane
approved these changes
Oct 26, 2017
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Oct 31, 2017
* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...
mattpr
pushed a commit
to mattpr/Prebid.js
that referenced
this pull request
Oct 31, 2017
* Add v1.0 adapter skeleton * Fix a typo in variable name declaration * Change spec dependencies * Add new describes for test * Move URL detechtion inside buildRequests method * Add necessary cases * Clean test cases * Export Quantcast adapter constants * Implemenent test cases * Fix wrong ports number * Correct test cases * Make string with single quote * Remove unused statements * Revert "Remove unused statements" This reverts commit 459ca31. * Remove unused statements * Change string to single quote * Fix sizes type * Fix the sizes propty name typo in the spec * Remove unused method, key value and comments * Update the spec * Change code using single quote * Update the first argument for interpretResponse method and its spec * Handle undefined Server Response * Add required params from the server response
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Nov 13, 2017
* tag '0.32.0' of https://github.com/prebid/Prebid.js: (44 commits) Prebid 0.32.0 Release Commenting out tests that are failing in IE10 (prebid#1710) Update dfp.buildVideoUrl to accept adserver url (prebid#1663) Update rubicon adapter with new properties and 1.0 changes (prebid#1776) Added adUnitCode for compatibility (prebid#1781) Remove 'supported' from analytics adapter info (prebid#1780) Add TTL parameter to bid (prebid#1784) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) ...
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Add v1.0 adapter skeleton * Fix a typo in variable name declaration * Change spec dependencies * Add new describes for test * Move URL detechtion inside buildRequests method * Add necessary cases * Clean test cases * Export Quantcast adapter constants * Implemenent test cases * Fix wrong ports number * Correct test cases * Make string with single quote * Remove unused statements * Revert "Remove unused statements" This reverts commit 459ca31. * Remove unused statements * Change string to single quote * Fix sizes type * Fix the sizes propty name typo in the spec * Remove unused method, key value and comments * Update the spec * Change code using single quote * Update the first argument for interpretResponse method and its spec * Handle undefined Server Response * Add required params from the server response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
Other information
N/A